GPC Consumer adaptor logging improvements#331
Merged
Conversation
|
Images built and published to ECR using a Build Id of PR-341-b0f1eea |
There was a problem hiding this comment.
Pull request overview
This PR enhances outbound WebClient logging for SDS calls to improve traceability during investigations by adding explicit request/response logs and additional error logging.
Changes:
- Add INFO-level logging for outbound requests and introduce a new response-status logging filter.
- Add an error log hook to SDS WebClient requests.
- Update SDS WebClient filter wiring to include the new response logging filter.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| service/src/main/java/uk/nhs/adaptors/gpc/consumer/web/WebClientFilterService.java | Adds outbound request INFO log, refines header debug log message, and introduces logResponse() filter. |
| service/src/main/java/uk/nhs/adaptors/gpc/consumer/sds/SdsClient.java | Adds doOnError logging for SDS request failures. |
| service/src/main/java/uk/nhs/adaptors/gpc/consumer/sds/builder/SdsRequestBuilder.java | Registers the new response logging filter in the SDS WebClient filter chain. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Images built and published to ECR using a Build Id of PR-341-b0f1eea |
|
Images built and published to ECR using a Build Id of PR-342-05e9935 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The adaptor logging improvements
Why
The robust and clear structured logging helps during investigations and all kinds of enquiries
Type of Change
Please check the option(s) that apply.
Checklist